Refactor/deprecated - #206
Merged
Merged
Conversation
…re of new default in KeyValueAccess. Move FileLazyRead to FsIoPolicy. Signed-off-by: Caleb Hulbert <cmhulbert@gmail.com>
…`. Extract and generify TrackingKeyValueAccess to be more reusable Signed-off-by: Caleb Hulbert <cmhulbert@gmail.com>
bogovicj
approved these changes
Feb 17, 2026
Contributor
|
If / when we remove the deprecated |
…for the IoPolicy configuration. Signed-off-by: Caleb Hulbert <cmhulbert@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
introduce package-private
BufferedKvaLockedChannel. The purpose is to use it indefaultimplementaions forKeyValueAccessto allow implementation ofKeyValueAccessto delete their (now deprecated) overrides, and only have to implementcreateReadDataandwrite. The expectation is that the now deprecatedlockForReading/Writingmethods should work identical, but we should not aim to make this a guarantee.remove the
lockForReadinglockForWritingmethods fromFileSystemKeyValueAccessadd
N5ConcurrentModificationException(currently not used in N5, but we at least want it for google cloud and s3).refactor
Trackinglogic inShardTestto be more reusable.DelegateKeyValueAccess,TrackingKeyValueAccessandTrackingN5Writer